Conversation
sciwhiz12
requested changes
Sep 22, 2026
| } | ||
|
|
||
| @Nullable | ||
| private static FieldInfo getFieldInfo(ClassInfo classInfo, List<ClassInfo> parents, boolean isStatic, String fieldName, @Nullable String fieldDesc) { |
Member
There was a problem hiding this comment.
Why is this method private, when the original method descriptor is public? The other related methods for methods, annotations, etc., are public, so I think this should be as well.
In that case, we should also deprecate the original (now bouncer) method.
Contributor
Author
There was a problem hiding this comment.
hm ok, that makes sense. it's not really clear to me what's meant to be public or not (is it intentional?), so I tend to just choose the more conservative option and keep things private
I'll push an update for those two things
sciwhiz12
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a field changes types it should be considered incompatible.