Added O2IMS POST REST API #972

NMSVishal · 2025-09-18T12:48:35Z

Added POST API for accepting provisioning request payload

nephio-prow · 2025-09-18T12:48:39Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liamfallon for approval by writing /assign @liamfallon in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nephio-prow · 2025-09-18T12:48:47Z

Hi @NMSVishal. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

liamfallon · 2025-09-22T08:21:35Z

/ok-to-test

arora-sagar · 2025-09-30T07:06:21Z

operators/focom-operator/internal/controller/focomprovisioningrequest_helpers.go

@NMSVishal Is it needed to remove the blank space there? I think we can leave it

done,added the blacnk space as it was there earlier

I think you need to remove this file from your changes you have to amend the earlier commit.

arora-sagar · 2025-09-30T07:08:17Z

operators/o2ims-operator/README.md

 done
 ```
+
+## Provisioning Request Phases:


@NMSVishal I think it is better to put this around here --> https://github.com/nephio-project/nephio/tree/main/operators/o2ims-operator#operator-logic

arora-sagar · 2025-09-30T07:08:47Z

operators/o2ims-operator/README.md

+
+## Provisioning Request Phases:
+
+Enumeration value 	Description 


Can you make it into a table?

arora-sagar · 2025-09-30T07:09:40Z

operators/o2ims-operator/api/app.py

+    if data.get('templateName')=='' or data.get('templateVersion')=='' or data.get('templateParameters')=='':
+        logging.info("One of the Parameter from templateName,templateVersion,templateParameters is null.. ")
+        return jsonify({"status":{"updateTime":"","message":f"O2IMS Deployment Failed,{e}","provisioningPhase":"FAILED"}}),500
+


Can you remove the additional whitespace?

operators/o2ims-operator/api/app.py

arora-sagar · 2025-09-30T08:09:26Z

operators/o2ims-operator/controllers/manager.py

 from provisioning_request_validation_controller import *
 from datetime import datetime
 import logging
 import kopf


@NMSVishal Now this is not an operator because it is not accepting any CRD it is just a flask server then we should remove kopf part

hi @arora-sagar, we still need the kopf because flaks expose the REST API and then internally it creates the O2IMS CR so the exisiting kopf of O2IMS is needed.

Okay, for the moment, this approach is fine, but I don't understand the benefit of maintaining the CR in the ETCD.If nobody will really use it. To remove the CR logic, we need to make some changes. We can do it later

If we want to remove the Kopf ,it will be compltely ,API micro-service and I will need more time for its implementation.
At initial I had represented my approach showcasing reutilizing KOPF codebase

Could this be done now? If the plan is to move to a REST server, we should remove the controller logic. Also, as @arora-sagar mentioned, it is no longer a controller.

@efiacor Okay, it seems it requires a bit more work to remove controller logic. So we can move that to the next release for the moment, I am fine with accepting it like this.

@arora-sagar @NMSVishal #972 (comment)

operators/o2ims-operator/requirements.txt

NMSVishal · 2025-10-06T08:08:46Z

operators/o2ims-operator/.env

@@ -0,0 +1 @@
+RUNNING_ENVIRONMENT=TEST    # TEST for binary run, CLUSTER for k8s cluster based run 


Since .env file is not needed anymore ,I am removing it

operators/o2ims-operator/controllers/utils.py

operators/o2ims-operator/api/app.py

efiacor · 2025-10-22T11:03:20Z

@arora-sagar @NMSVishal @gvbalaji
May not e directly related but could we get some more reviews on this PR - nephio-project/api#69

NMSVishal · 2025-11-12T06:39:42Z

Resolved all conflicts

Added O2IMS POST REST API

e467a3a

nephio-prow bot requested review from johnbelamaric and liamfallon September 18, 2025 12:48

nephio-prow bot added the needs-ok-to-test label Sep 18, 2025

arora-sagar requested review from arora-sagar and removed request for johnbelamaric September 18, 2025 13:02

nephio-prow bot added ok-to-test and removed needs-ok-to-test labels Sep 22, 2025

arora-sagar reviewed Sep 30, 2025

View reviewed changes

operators/o2ims-operator/api/app.py Outdated Show resolved Hide resolved

arora-sagar reviewed Sep 30, 2025

View reviewed changes

operators/o2ims-operator/api/app.py Outdated Show resolved Hide resolved

arora-sagar reviewed Sep 30, 2025

View reviewed changes

operators/o2ims-operator/requirements.txt Show resolved Hide resolved

NMSVishal commented Oct 6, 2025

View reviewed changes

NMSVishal added 2 commits October 6, 2025 14:10

Resolved all the comments

e3795a2

Implemented GET STATUS API

30c4d89

arora-sagar reviewed Oct 13, 2025

View reviewed changes

operators/o2ims-operator/controllers/utils.py Outdated Show resolved Hide resolved

arora-sagar reviewed Oct 13, 2025

View reviewed changes

operators/o2ims-operator/api/app.py Show resolved Hide resolved

NMSVishal added 3 commits November 10, 2025 16:22

Fix indentation for CREATION_TIMEOUT variable

d0e256e

Pin python-dateutil version to 2.8.2

46a3370

Merge branch 'main' into feature/o2ims-rest-api

f393a6d

gofmmt focomprovisioningrequest_helpers.go file

b596fa4

NMSVishal closed this Nov 13, 2025

NMSVishal reopened this Nov 13, 2025


		## Provisioning Request Phases:

		Enumeration value Description

		@@ -0,0 +1 @@
		RUNNING_ENVIRONMENT=TEST # TEST for binary run, CLUSTER for k8s cluster based run No newline at end of file

Added O2IMS POST REST API #972

Are you sure you want to change the base?

Added O2IMS POST REST API #972

Uh oh!

Conversation

NMSVishal commented Sep 18, 2025

Uh oh!

nephio-prow bot commented Sep 18, 2025

Uh oh!

nephio-prow bot commented Sep 18, 2025

Uh oh!

liamfallon commented Sep 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NMSVishal Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

efiacor commented Oct 22, 2025

Uh oh!

NMSVishal commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NMSVishal Oct 6, 2025 •

edited

Loading