Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to job tracking and policy status reporting in the policy management system. The main changes include integrating a
JobStoreinto the policy manager and runner, enabling detailed tracking of job executions for each policy, and exposing comprehensive policy/job status information via the server status endpoint. Additionally, thePolicyRunnerlogic is refactored for cleaner job lifecycle management and metric reporting.Job tracking and policy status enhancements:
JobStoreinstance intoPolicyManagerand passed it to eachPolicyRunner, allowing centralized tracking of jobs associated with policy executions. (worker/worker/policy/manager.py,worker/worker/policy/runner.py) [1] [2] [3] [4] [5] [6]get_policy_statusesmethod toPolicyManagerthat returns a list of policies with their status and associated jobs, including those with jobs but no active runner. (worker/worker/policy/manager.py)PolicyRunner job lifecycle and metric refactoring:
PolicyRunner.runto use helper methods for job creation, status updates, and metric recording, ensuring job status is updated on both success and failure, and added more granular metrics and logging. (worker/worker/policy/runner.py) [1] [2] [3] [4]API and test updates:
worker/worker/server.py)worker/tests/policy/test_manager.py,worker/tests/test_server.py) [1] [2]