Setup GitHub action for running tests - #5
Open
stephenmathieson wants to merge 7 commits into
Open
Conversation
This patch adds a GitHub action for running the tests and updates the `docker-compose` configuration (which enables the tests to run/pass).
| - uses: actions/checkout@v1 | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: '12' |
Collaborator
Author
There was a problem hiding this comment.
Tests fail on Node 14. Haven't investigated why 馃し
Collaborator
Author
|
Looks like the DB isn't ready for connections yet. I'll take a look at it tomorrow morning. |
Owner
|
Anything I can do to help here, @stephenmathieson? |
Collaborator
Author
|
Thanks for the invite (and I ended up spending all day Friday fixing a pretty scary security issue for work and didn't find any time to finish this. I'll get to it in the next few days tho! |
To avoid seeing tons of "_Creating a duplicate database object for the same connection_" warnings, we're now disconnecting from the database after generating code.
This reverts commit 4832356. While the change prevented the warnings locally, it had no effect in CI 馃し
Wait until we've connected before running a query
This reverts commit ed25e3f. I have no idea what's going on
Collaborator
Author
|
Messed around and tried a couple things, but had no luck. Not sure what's going on in CI. I'll take another stab at this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to add the feature discussed in #2, but want to make sure I don't break anything by doing so. This patch adds a GitHub action for running the tests and updates the
docker-composeconfiguration (which enables the tests to run/pass).