added logs for calico #1250
Draft
added logs for calico #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Avramenko <[email protected]>
| Timeout time.Duration `default:"5s" desc:"Context timeout for kubernetes queries" split_words:"true"` | ||
| WorkerCount int `default:"8" desc:"Number of log collector workers" split_words:"true"` | ||
| AllowedNamespaces string `default:"(ns-.*)|(nsm-system)" desc:"Regex of allowed namespaces" split_words:"true"` | ||
| AllowedNamespaces string `default:"(^ns-.*)|(nsm-system)|spire|calico-vpp-dataplane" desc:"Regex of allowed namespaces" split_words:"true"` |
Member
There was a problem hiding this comment.
Calico is not a default value for the env.
Suggested change
| AllowedNamespaces string `default:"(^ns-.*)|(nsm-system)|spire|calico-vpp-dataplane" desc:"Regex of allowed namespaces" split_words:"true"` | |
| AllowedNamespaces string `default:"(^ns-.*)|(nsm-system)|(spire)" desc:"Regex of allowed namespaces" split_words:"true"` |
denis-tingaikin
requested changes
Dec 28, 2021
Member
denis-tingaikin
left a comment
denis-tingaikin
left a comment
There was a problem hiding this comment.
Please fix the comment.
Signed-off-by: Mikhail Avramenko <[email protected]>
Signed-off-by: Mikhail Avramenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko [email protected]