Skip to content

[WIP] Fix the failing GitHub Actions job 'build' - #335

Merged
nev21 merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Sep 12, 2026
Merged

[WIP] Fix the failing GitHub Actions job 'build'#335
nev21 merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
  • Inspect the failing GitHub Actions run and job logs
  • Identify the root cause in the docs/build pipeline
  • Pin or adjust the incompatible type dependency with the smallest possible change
  • Add or update focused validation for the docs/build path if needed
  • Run targeted install/build/docs verification
  • Scan changed files for secrets and finalize validation

Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
@nev21 nev21 closed this Sep 11, 2026
@nev21 nev21 reopened this Sep 11, 2026
@nev21

nev21 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@copilot why not just change the version of node that is used for publishing?

Copilot stopped work on behalf of nev21 due to an error September 11, 2026 19:35
Copilot AI requested a review from nev21 September 11, 2026 19:35

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot why not just change the version of node that is used for publishing?

Changing the publishing workflow’s Node version would not have fixed this failure by itself. The job was installing @types/node@26.x from the package semver ranges, and Typedoc running on TypeScript 5.2.2 fails against those type definitions regardless of the runner’s Node version. Pinning @types/node fixes the actual compatibility break and keeps local/docs builds deterministic too.

@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.30%. Comparing base (455966c) to head (bda421a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files         137      137           
  Lines        6388     6388           
  Branches     1640     1640           
=======================================
  Hits         6088     6088           
  Misses        300      300           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nev21
nev21 marked this pull request as ready for review September 12, 2026 14:47
Copilot AI lite review requested due to automatic review settings September 12, 2026 14:47
@nev21
nev21 requested review from a team as code owners September 12, 2026 14:47
@nev21
nev21 enabled auto-merge (squash) September 12, 2026 14:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused dependency and shrinkwrap updates address the build compatibility issue with no unresolved review comments.

Pull request overview

Pins @types/node to 24.9.1 to restore TypeScript and documentation build compatibility.

Changes:

  • Updated dependency pins in the root, core, and Chai shim manifests.
  • Regenerated Rush shrinkwrap entries and metadata.
File summaries
File Description
shim/chai/package.json Pins the Chai shim dependency.
package.json Pins the root Node.js type definitions.
core/package.json Pins the core development dependency.
common/config/rush/npm-shrinkwrap.json Records the resolved dependency updates.
Review details

Files not reviewed (1)

  • common/config/rush/npm-shrinkwrap.json: Generated file
  • Files reviewed: 3/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nevware21-bot nevware21-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by nevware21-bot

@nev21
nev21 merged commit 25dae02 into main Sep 12, 2026
12 checks passed
@nev21
nev21 deleted the copilot/fix-failing-github-actions-job branch September 12, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants