[WIP] Fix the failing GitHub Actions job 'build' - #335
Conversation
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
|
@copilot why not just change the version of node that is used for publishing? |
Changing the publishing workflow’s Node version would not have fixed this failure by itself. The job was installing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 137 137
Lines 6388 6388
Branches 1640 1640
=======================================
Hits 6088 6088
Misses 300 300 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The focused dependency and shrinkwrap updates address the build compatibility issue with no unresolved review comments.
Pull request overview
Pins @types/node to 24.9.1 to restore TypeScript and documentation build compatibility.
Changes:
- Updated dependency pins in the root, core, and Chai shim manifests.
- Regenerated Rush shrinkwrap entries and metadata.
File summaries
| File | Description |
|---|---|
shim/chai/package.json |
Pins the Chai shim dependency. |
package.json |
Pins the root Node.js type definitions. |
core/package.json |
Pins the core development dependency. |
common/config/rush/npm-shrinkwrap.json |
Records the resolved dependency updates. |
Review details
Files not reviewed (1)
- common/config/rush/npm-shrinkwrap.json: Generated file
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nevware21-bot
left a comment
There was a problem hiding this comment.
Approved by nevware21-bot
Uh oh!
There was an error while loading. Please reload this page.