Restore main branch to service released 7.9.2 version #2193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last year, I started a project to see if New XKit could include all of its extension code in the XKit package, making all extension updates go through Mozilla/Google review, as required to stay listed on their stores. We merged #2148 into master as part of this (making various additional changes afterward), and made a "legacy" 7.9.2 branch with the code prior to that change that would service the currently-released 7.9.2 XKit version as it always has: by distributing extension updates to users directly through github. Due to a number of factors, namely issues with Mozilla extension review and various consequences resulting from that, it's clear that this is not a viable path forward.
This, therefore, restores the 7.9.2 branch's contents back to master, dropping the unreleased changes and shelving the idea for the foreseeable future (we can make a 7.10.0 branch to be the "shelf"). Thus, "New" XKit will continue to be disallowed on extension stores, as is appropriate given our stance that XKit Rewritten is the future of XKit and our recommendation that people use it. "New" XKit will also thus continue to have any changes that we make to it deployed rapidly with minimal hassle, in case we want to keep parts of it working for the userbase that still has it installed (which definitely exists; I regularly see posts with screenshots that prove this).
This codebase is the work of many and there's a ton of history in it. In that sense I want to show it some respect, and not leave its primary branch in a state of limbo. (To that end, I also have a cleanup of the build tooling to go along with this, which I'll put in another PR.)
Note: the first commit is generated with
git checkout --no-overlay 7.9.2 -- ., so in a sense it's a machine-generated diff.For comment: should we do this and should we do this this way? There are other methods (though I think force pushing
7.9.2to the master branch would be a pretty terrible idea and that's the main relevant other method, to my knowledge, so... maybe there aren't really.)Testing steps
The cleanest way to test this is probably to check it out to the "master" branch of a fork and make sure the CI and deployment actions work; I'll probably do so at some point and show the results in a comment below.