-
Notifications
You must be signed in to change notification settings - Fork 423
refactor: Updated @langchain/core instrumentation to subscribe to events emitted
#3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: Updated @langchain/core instrumentation to subscribe to events emitted
#3493
Conversation
@langchain/core instrumentation to subscribe to events emitted
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3493 +/- ##
===========================================
+ Coverage 81.46% 97.64% +16.17%
===========================================
Files 409 422 +13
Lines 54383 55857 +1474
Branches 1 1
===========================================
+ Hits 44305 54539 +10234
+ Misses 10078 1318 -8760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
51a3401 to
f44078a
Compare
9f9d6b0 to
7c0304a
Compare
7c0304a to
427f4c0
Compare
427f4c0 to
a050bbb
Compare
bizob2828
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as google gen ai. we need to look at the spec for enabling/disabling AI monitoring, not sure if we have this correct
| */ | ||
| const trackingPkgs = [ | ||
| '@azure/openai', | ||
| '@langchain/core/tools', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not what you may think it is. This is to increment a tracking metric which doesn't apply here because we instrument these packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this was technically broken. The package that currently gets registered is @langchain/core. So if a customer wants to disable langchain instrumentation they can set this.config.instrumentation['@langchain/core'].enabled to false. We will have to update angler to properly track this package though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not create the Supportability metric if I omit this. Because @langchain/core itself is never required directly, I had to add its children packages here in order for the metrics to be created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's talk about this as well. this is not the place for this
This PR resolves #3442.