fix: Updated MessageConsumerSubscriber to wait for consumer callback to end when it is a promise #3510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
requested changes
Nov 17, 2025
Contributor
jsumners-nr
left a comment
jsumners-nr
left a comment
There was a problem hiding this comment.
I think we need to be a bit more generic in our detection and handling. We'll also need to rebase in order to get the AWS tests working.
…to end when it is a promise
bizob2828
force-pushed
the
consumer-fix
branch
from
fd32d83 to
3dd04c0
Compare
jsumners-nr
approved these changes
Nov 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3510 +/- ##
==========================================
- Coverage 97.77% 97.64% -0.13%
==========================================
Files 420 420
Lines 55711 55724 +13
Branches 1 1
==========================================
- Hits 54472 54414 -58
- Misses 1239 1310 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3503 we updated the
MessageConsumerSubscriberto properly end transactions that were creating during the consumption of a message.However, we didn't have proper test coverage to ensure that if a consumption message callback was a promise that it would properly wait for the
promise to resolve before ending the transaction. This PR fixes that.
How to Test
Related Issues
Closes #3509