Log readme file path + format a bit previous logs #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimateos
force-pushed
the
PR/log-readme
branch
from
75a3b3f to
5d63e44
Compare
dimateos
changed the title
newren
requested changes
Mar 20, 2025
newren
requested changes
Mar 20, 2025
Owner
newren
left a comment
newren
left a comment
There was a problem hiding this comment.
In addition to the comments on individual lines...rather than have 3 commits where one commit primarily just undoes the change of the other, let's make the history clean
dimateos
commented
May 6, 2025
Contributor
Author
dimateos
left a comment
dimateos
left a comment
There was a problem hiding this comment.
Changes were reviewed (not sure why there are some still pending, now outdated)
newren
requested changes
Jun 6, 2025
Owner
newren
left a comment
newren
left a comment
There was a problem hiding this comment.
Hi, sorry for the delay.
This version looks pretty good, but the commit message needs some touching up:
- Commit messages should use imperative tense, same as with the git project
- Lines should be wrapped at 72 characters.
So, the lines before the Signed-off-by would look something like:
filter-repo: log README file from reports directory
Make the reports README file more discoverable by logging it. Further,
to allow control+click opening of the file inside certain
terminals/IDEs, add quotes around the filename. Add quotes around the
directory that is already displayed as well, for the same reason.
Make the reports README file more discoverable by logging it. Further, to allow control+click opening of the file inside certain terminals/IDEs, add quotes around the filename. Add quotes around the directory that is already displayed as well, for the same reason. Signed-off-by: Diego Mateos <[email protected]>
Contributor
Author
|
Hello! Thanks for the response, I really appreciate the effort. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the output dir in the log, but could not control+click due to a missing space:
(underline appears on hover on clickable paths/links)
With this PR, I added the space plus a bit formatting.
I also added the readme file because opening files with control+click is more convenient than folders IMO.
Demo showing the control+click in vscode:
I split the commits along with detailed descriptions, but I can squash them or whatever to may need
Best regards!