-
Notifications
You must be signed in to change notification settings - Fork 196
feat: add virtual scroll to member list #4625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aa1ba43 to
fe5d83d
Compare
|
@nfebe |
fe5d83d to
2ca5cf7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4625 +/- ##
==========================================
- Coverage 9.86% 1.89% -7.98%
==========================================
Files 124 98 -26
Lines 6173 5437 -736
Branches 1423 1433 +10
==========================================
- Hits 609 103 -506
+ Misses 5441 5210 -231
- Partials 123 124 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2ca5cf7 to
0427db1
Compare
nfebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like that it doesn't appear when the aren't that many members.
st3iny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for #4581 please.
|
Done, conflicts need to be addressed though. |
Signed-off-by: ailkiv <[email protected]>
0427db1 to
66fb301
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
st3iny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Thank you for the PR.
Please use the virtual scroller package virtua we already include to prevent adding another dependency.
Here is a usage example from the Contacts code:
contacts/src/components/ContactsList.vue
Lines 67 to 76 in 416d03f
| <VList v-slot="{ item, index }" | |
| ref="scroller" | |
| class="contacts-list" | |
| :data="filteredList"> | |
| <ContactsListItem :key="item.key" | |
| :index="index" | |
| :source="item" | |
| :reload-bus="reloadBus" | |
| :on-select-multiple-from-parent="onSelectMultiple" /> | |
| </VList> |
Here is some more documentation: https://github.com/inokawa/virtua#vue
|
I looked into the issue more deeply. With groups of over 1,000, there is a noticeable delay in receiving data. Therefore, I suggest limiting the number of participants to a maximum of 200. If the team is larger, we will not display participants with an empty search. What do you think? PR in circles: nextcloud/circles#2112 |
|
@AIlkiv That makes sense. If the fetching is becoming the bottleneck instead of the rendering. |
My proposed solution:
Demo:
contacts.mp4