-
Notifications
You must be signed in to change notification settings - Fork 196
feat(teams): Implement quick create for team resources #4846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
GVodyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Apart from a few things to fix looking really good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than @GVodyanov's comments, I suggested wording changes and fixes to capitalization.
Just a small visual thing, but the margins above the "Create" title should also be increased, maybe double what it is currently.
nfebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes implemented.
- Outline icons have not be reverted I will wait for confirmation from @kra-mo or @marcoambrosini AFAIK there was a resolution that start using those and migrate existing icon uses cases to that.
|
65f3cb3 to
2cff0a6
Compare
@GVodyanov and @hamza221 are correct. Icons that were already a single line should not be outlined. |
Those where fixed already. |
GVodyanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: nfebe <[email protected]>
2cff0a6 to
81ef1b4
Compare
Resolved. |



Introduction of quick create actions in teams UI
Screenshots
Screencasts
Resolves : nextcloud/circles#2156