Skip to content

Conversation

@lukasdotcom
Copy link
Member

@lukasdotcom lukasdotcom commented Aug 15, 2025

This does the minimum to fix this adding a monthly option for period that resets every month or exact multiple of months. This could also be used for yearly as long as a start date of January is ok. The date range was originally planned to be put into the admin settings, but I think it looks better in personal settings.
Resolves part of: #250

Admin Settings

image image

Personal Settings

image image

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is no value for quota_period, one loads the admin settings page, switches Reset quota every from 30 days to 30 months, then it fails to save because it tries to save without the "day" param. It should be one by default if it's not set, just like it is visually 1 by default.

Could you also add a bit more descriptions of what the methods do?

@lukasdotcom
Copy link
Member Author

lukasdotcom commented Aug 21, 2025

When there is no value for quota_period, one loads the admin settings page, switches Reset quota every from 30 days to 30 months, then it fails to save because it tries to save without the "day" param. It should be one by default if it's not set, just like it is visually 1 by default.

Could you also add a bit more descriptions of what the methods do?

I remember that issue, but forgot about it when I manually fixed the config. Thanks for noticing it. Is fixed and rebased now.

@lukasdotcom lukasdotcom requested a review from julien-nc August 21, 2025 14:03
@lukasdotcom lukasdotcom merged commit 199b0ed into main Aug 25, 2025
29 checks passed
@lukasdotcom lukasdotcom deleted the feat/quota-dates branch August 25, 2025 12:25
@kyteinsky kyteinsky mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants