Skip to content

chore: update php dev dependencies#971

Merged
saw-jan merged 6 commits intorelease/3.0from
chore/update-php-dependencies
Mar 11, 2026
Merged

chore: update php dev dependencies#971
saw-jan merged 6 commits intorelease/3.0from
chore/update-php-dependencies

Conversation

@saw-jan
Copy link
Collaborator

@saw-jan saw-jan commented Feb 2, 2026

Description

Add php8.4 in the matrix and the required dev dependencies update.

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@saw-jan saw-jan marked this pull request as draft February 2, 2026 06:59
@saw-jan saw-jan mentioned this pull request Feb 2, 2026
8 tasks
@saw-jan saw-jan force-pushed the chore/update-php-dependencies branch 2 times, most recently from 83826e9 to d8b1e92 Compare February 2, 2026 10:04
@saw-jan
Copy link
Collaborator Author

saw-jan commented Feb 2, 2026

Needs juliusknorr/nextcloud-docker-dev#447 to be merged image is updated with the fix

@saw-jan saw-jan force-pushed the chore/update-php-dependencies branch 2 times, most recently from 431e2c7 to a8debdb Compare February 6, 2026 05:48
<data>
"""
Then the HTTP status code should be "400"
Then the HTTP status code should be "400" or "500"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not do this. I am currently looking at why we are getting 500 error for a request with invalid json when using ghcr.io/juliusknorr/nextcloud-dev-php83:master

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this. we need php8.4 going. I have creates a wp to rever this test changes. https://community.openproject.org/wp/72960

@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

saw-jan added 6 commits March 11, 2026 16:19
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan saw-jan force-pushed the chore/update-php-dependencies branch from bc5b79b to 548eb40 Compare March 11, 2026 10:35
@github-actions
Copy link

JS Code Coverage

Coverage after merging chore/update-php-dependencies into release/3.0 will be
92.27%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js85.92%33.33%50%87.59%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js64.71%100%0%73.33%10–11, 14–15
src/components
   AdminSettings.vue96.06%94.74%97.10%96.19%1003–1005, 1025–1028, 568, 568–569, 569, 606–612, 715–716, 720–721, 724–725, 729–730, 740–745, 788–790, 802–805, 818–820, 842–844, 927–929, 964–967
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue85.82%63.64%100%87.39%49–56, 64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue94.74%80%100%95.35%49–53
src/components/tab
   EmptyContent.vue97.46%90.48%100%98.24%107–111
   SearchInput.vue95.31%92.96%94.74%95.78%138–139, 192, 203–208, 267–269, 285–287, 291–296
   WorkPackage.vue86.22%72.50%93.33%87.62%107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
   workpackageHelper.js89.84%82.14%88.89%92.15%100–102, 156–157, 23–27, 34, 34, 36, 36, 50–52, 54, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.14%86.32%90.48%95.40%366–371, 374, 390, 507–510, 515–520, 525–530, 536–539, 542, 558, 558, 599–603, 613–615, 638–639, 647–649, 678–680, 702–704, 713–717
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.95%94.34%93.75%95.10%104–107, 143, 154–155, 189–199, 248–250

@saw-jan saw-jan marked this pull request as ready for review March 11, 2026 10:42
@saw-jan saw-jan self-assigned this Mar 11, 2026
@saw-jan saw-jan added the backport PR needs backporting label Mar 11, 2026
@github-actions
Copy link

PHP Code Coverage

Coverage after merging chore/update-php-dependencies into release/3.0 will be
66.92%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
integration_openproject/server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   OIDCClientMapper.php0%100%0%0%29, 40–49, 52
   TokenEventFactory.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
   Application.php36.59%100%50%35.53%105–107, 110–114, 116–121, 123–124, 127, 132–133, 135–138, 140, 142, 144, 148–151, 153–164, 166, 169, 173, 177–179, 212
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
   ConfigController.php75.12%100%64.71%75.56%114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 541–543, 577–581, 592, 606–609, 617, 621–624, 660, 663–678, 695–700, 702–703, 705–707, 710, 712–728, 742–745, 747–751
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php71.03%100%100%70.21%117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
   FilesController.php86.99%100%83.33%87.18%178–179, 241, 250, 267–270, 275–277, 282–284, 293
   OpenProjectAPIController.php80.51%100%82.35%80.34%107, 146, 193–195, 198–205, 207–211, 213, 232, 257, 322, 372, 392, 439, 464–466, 469–473, 475, 66
   OpenProjectController.php96.45%100%80%96.95%241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%21
integration_openproject/server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php100%100%100%100%
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php0%100%0%0%30, 37–38, 40–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54
   LoadSidebarScript.php65.91%100%100%64.29%105, 77–88, 95, 98
   OpenProjectReferenceListener.php0%100%0%0%45–47, 54–55, 57, 59–60, 62–74
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
integration_openproject/server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 40–48, 50–58, 60–62, 64
   Version20100Date20250820101358.php0%100%0%0%38, 47–53, 56
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 40–43
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
   Version2900Date20250718065820.php0%100%0%0%23, 35–38, 40–41, 43–44, 47
integration_openproject/server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php88.46%100%100%87.50%62–63, 65
   DirectUploadService.php42.86%100%66.67%40%101, 62–65, 67–75, 95
   OauthService.php0%100%0%0%100–101, 40–42, 51–58, 60–66, 75–83, 94–99
   OpenProjectAPIService.php75.05%100%77.46%74.86%1006–1007, 1009,

Copy link
Collaborator

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@saw-jan saw-jan merged commit 8b5e6f3 into release/3.0 Mar 11, 2026
14 of 16 checks passed
@saw-jan saw-jan deleted the chore/update-php-dependencies branch March 11, 2026 11:16
saw-jan added a commit that referenced this pull request Mar 11, 2026
* chore: update php dev packages

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: fix lint errors

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: test with php 8.4

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: remove unwanted nextcloud env

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: fix postgress db service

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* test: accept 500 error on invalid json

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan added a commit that referenced this pull request Mar 12, 2026
* fix: handle op projects whose parent project is unknown (#988)

* fix: hanlding undisclosed and non-existing project parent



* test: fix vue unit tests



* test: add vue unit tests



* chore: add changelog entry



---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: add OP API request as debug log (#991)

* chore: add OP API request as debug log

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: add changelog entry

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* fix: use builtin exception class

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* fix: use https NC url in OP API requests (#992)

* fix: use https NC url in OP API requests

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: add changelog entry

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* test: add phpunit test

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: update php dev dependencies (#971)

* chore: update php dev packages

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: fix lint errors

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: test with php 8.4

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: remove unwanted nextcloud env

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: fix postgress db service

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* test: accept 500 error on invalid json

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan added a commit that referenced this pull request Mar 13, 2026
* chore: update php dev packages

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: fix lint errors

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: test with php 8.4

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: remove unwanted nextcloud env

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: fix postgress db service

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* test: accept 500 error on invalid json

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan added a commit that referenced this pull request Mar 13, 2026
* chore: update php dev packages

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: fix lint errors

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: test with php 8.4

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: remove unwanted nextcloud env

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: fix postgress db service

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* test: accept 500 error on invalid json

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR needs backporting feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants