Skip to content

ci: replace removed getUserManager in phpunit test#994

Merged
saw-jan merged 1 commit intomasterfrom
ci/replace-depreciated-method
Mar 11, 2026
Merged

ci: replace removed getUserManager in phpunit test#994
saw-jan merged 1 commit intomasterfrom
ci/replace-depreciated-method

Conversation

@nabim777
Copy link
Collaborator

@nabim777 nabim777 commented Mar 11, 2026

Description

getUserManager() was removed as part of the server changes nextcloud/server#58808

Related Issue or Workpackage

  • Fixes <issue_link>

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@github-actions
Copy link

JS Code Coverage

Coverage after merging ci/replace-depreciated-method into master will be
92.27%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js85.92%33.33%50%87.59%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js64.71%100%0%73.33%10–11, 14–15
src/components
   AdminSettings.vue96.06%94.74%97.10%96.19%1003–1005, 1025–1028, 568, 568–569, 569, 606–612, 715–716, 720–721, 724–725, 729–730, 740–745, 788–790, 802–805, 818–820, 842–844, 927–929, 964–967
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue85.82%63.64%100%87.39%49–56, 64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue94.74%80%100%95.35%49–53
src/components/tab
   EmptyContent.vue97.46%90.48%100%98.24%107–111
   SearchInput.vue95.32%92.96%94.74%95.79%139–140, 193, 204–209, 268–270, 286–288, 292–297
   WorkPackage.vue86.22%72.50%93.33%87.62%107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
   workpackageHelper.js89.84%82.14%88.89%92.15%100–102, 156–157, 23–27, 34, 34, 36, 36, 50–52, 54, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.12%86.21%90.48%95.38%374–379, 382, 398, 499–502, 507–512, 517–522, 528–531, 534, 550, 550, 591–595, 605–607, 630–631, 639–641, 670–672, 694–696, 705–709
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.95%94.34%93.75%95.10%104–107, 143, 154–155, 189–199, 248–250

@nabim777 nabim777 changed the title CI: Replace the depreceated methods CI: Use getUserManager() instead of container get(IUserManager::class) in test Mar 11, 2026
@nabim777 nabim777 changed the title CI: Use getUserManager() instead of container get(IUserManager::class) in test CI: Use getUserManager() instead of get(IUserManager::class) in test Mar 11, 2026
@nabim777 nabim777 changed the title CI: Use getUserManager() instead of get(IUserManager::class) in test CI: Replace depreceated getUserManager() Mar 11, 2026
@nabim777 nabim777 changed the title CI: Replace depreceated getUserManager() CI: In php unit test file replace depreceated getUserManager() Mar 11, 2026
@nabim777 nabim777 changed the title CI: In php unit test file replace depreceated getUserManager() CI: In php unit test file replace deprecated getUserManager() Mar 11, 2026
@nabim777 nabim777 changed the title CI: In php unit test file replace deprecated getUserManager() CI: Replace deprecated getUserManager() in php unit test file Mar 11, 2026
@nabim777 nabim777 self-assigned this Mar 11, 2026
@nabim777 nabim777 marked this pull request as ready for review March 11, 2026 08:33
@nabim777 nabim777 changed the title CI: Replace deprecated getUserManager() in php unit test file CI: Replace removed getUserManager() in php unit test file Mar 11, 2026
@saw-jan saw-jan changed the title CI: Replace removed getUserManager() in php unit test file ci: replace removed getUserManager in phpunit test Mar 11, 2026
@saw-jan saw-jan merged commit 1905a71 into master Mar 11, 2026
9 checks passed
@saw-jan saw-jan deleted the ci/replace-depreciated-method branch March 11, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants