Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 19, 2025

Fixes #5149

List Modal
Before Bildschirmfoto vom 2025-11-19 16-43-24 Bildschirmfoto vom 2025-11-19 16-43-38
Dark Bildschirmfoto vom 2025-11-19 16-40-12 Bildschirmfoto vom 2025-11-19 16-40-06
Bright Bildschirmfoto vom 2025-11-19 16-41-05 Bildschirmfoto vom 2025-11-19 16-41-28

@ChristophWurst
Copy link
Member Author

@nimishavijay could you please give early feedback? Is the approach acceptable design-wise?

@nimishavijay
Copy link
Member

Nice improvements on the visual design aspects like rounding corners etc. I agree that the color contrast can be improved, but going with such bright colours seems like possibly a regression design-wise.

We could use very dark and very light versions of the tag color, similar to before, and additionally add a 1px border. Something like this:
text colour: color-mix(in srgb, [tag color] 25%, var(--color-main-text) 100%)
background: color-mix(in srgb, [tag color] 25%, var(--color-main-background) 100%)
border: color-mix(in srgb, [tag color] 50%, var(--color-main-background) 100%)

since --main-text and --main-bg always have very high contrast, it should work. What do you think?

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 20, 2025

The rounding is a side effect of deduplicating four copies of the more or less same code for tags 🌝

The tags will look like this with the suggested CSS:

Bildschirmfoto vom 2025-11-20 14-53-39

This works in terms of text readability but we'll lose most of the color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not all tags are readable due to background contrast

3 participants