Add rememberme checkbox #56343
Open
Add rememberme checkbox #56343
+101
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
icewind1991,
nfebe,
salmart-dev,
sorbaugh and
susnux
and removed request for
a team
Contributor
Author
|
/compile / |
ChristophWurst
approved these changes
Nov 10, 2025
| ITrustedDomainHelper $trustedDomainHelper, | ||
| string $user = '', | ||
| string $password = '', | ||
| bool $rememberme = false, |
Member
There was a problem hiding this comment.
Suggested change
| bool $rememberme = false, | |
| bool $remember_me = false, |
for consistency with the other parameters? not sure
Contributor
Author
There was a problem hiding this comment.
That would force me to rename all the camelCase to rememberMe then for consistency 😒
Only present if allowed by configuration. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
come-nc
force-pushed
the
feat/add-rememberme-checkbox
branch
from
5bef2d7 to
6eb9804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a remember me checkbox to the login form.
Checklist
3. to review, feature component)stable32)