[stable31] fix(sharing): allow federated shares to non-trusted servers #56968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Dec 11, 2025
When `showFederatedSharesToTrustedServersAsInternal` is enabled, the trusted server filter was incorrectly applied to both internal and external sharing sections. This prevented users from sharing with federated users on non-trusted servers via the external share UI. The filter now only applies to the internal section, allowing non-trusted federated shares to appear in the external section. Fixes: #56622 Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
backport/56652/stable31
branch
from
11f97ae to
9257378
Compare
nfebe
approved these changes
Dec 16, 2025
Contributor
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56652
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.