Skip to content

fix(hpb-service): An account is not expired if Unauthorized is returned. #16228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(hpb-service): An account is not expired if Unauthorized is returned. #16228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/BackgroundJob/CheckHostedSignalingServer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,6 @@ protected function run($argument): void {
if ($e->getCode() === Http::STATUS_NOT_FOUND) {
// Account was deleted, so remove the information locally
$accountInfo = ['status' => 'deleted'];
} elseif ($e->getCode() === Http::STATUS_UNAUTHORIZED) {
// Account is expired and deletion is pending unless it's reactivated.
$accountInfo = ['status' => 'expired'];
} else {
// API or connection issues - do nothing and just try again later
return;
Expand Down
2 changes: 0 additions & 2 deletions lib/Controller/HostedSignalingServerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ public function deleteAccount(): DataResponse {
} catch (HostedSignalingServerAPIException $e) {
if ($e->getCode() === Http::STATUS_NOT_FOUND) {
// Account was deleted, so remove the information locally
} elseif ($e->getCode() === Http::STATUS_UNAUTHORIZED) {
// Account is expired and deletion is pending unless it's reactivated.
} else {
// API or connection issues - do nothing and just try again later
return new DataResponse(['message' => $e->getMessage()], Http::STATUS_INTERNAL_SERVER_ERROR);
Expand Down
Loading