Skip to content

fix(notifications): open conversation from notification action without page reload - #20162

Merged
Antreesy merged 1 commit into
mainfrom
fix/notification-action-no-reload
Nov 5, 2026
Merged

Antreesy merged 1 commit into
mainfrom
fix/notification-action-no-reload

Conversation

@jancborchardt

@jancborchardt jancborchardt commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

☑️ Resolves

When a Talk conversation is already open and you click on "View chat" in a notification from the header notification dropdown, the entire page refreshes. Instead, it could simply know that we are already in Talk and just change to the relevant conversation / message.
This already doesn’t happen when you are on the Home view.

Additional closing of the notification dropdown done in nextcloud/notifications#3572

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (ClaudeCode:claude-opus-5-5)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screencast.From.2026-11-05.13-18-42.webm
Screencast.From.2026-11-05.13-21-00.webm

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

…t page reload

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought I merged a fix like this already

@Antreesy

Antreesy commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

@Antreesy

Antreesy commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

/backport to stable34

@Antreesy

Antreesy commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

/backport to stable33

@jancborchardt

Copy link
Copy Markdown
Member Author

@Antreesy I did search but couldn’t find anything. :) As said it does work when on the Home view.
Can you also check out the notifications PR? nextcloud/notifications#3572

@Antreesy

Antreesy commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Yes, I had it locally, didn't submit since the last time. All good =)

Can you also check out the notifications PR?

Will check a bit later. Talk app part is going to today's releases, thus the prompt merging here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits bug design papercut

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants