Repository navigation
fix: correctly specify dependency visibility of internal library - #100
Merged
Merged
Conversation
jatkinson1000
approved these changes
Oct 28, 2026
jatkinson1000
left a comment
jatkinson1000
left a comment
Contributor
There was a problem hiding this comment.
Not run myself, but your reasoning at the code changes look sensible.
Only comment is that I do not quite understand the comment and have suggested what I think to be clearer wording at your discretion.
Since the internal library is static, we need to propagate the dependencies to the targets that use it so they can resolve all symbols when being linked. The include directories should stay private since we don't expose dependency headers in the public headers. By public headers we mean: - Grid.hpp - Partitioner.hpp - DomainUtlis.hpp Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com>
Mikolaj-A-Kowalski
force-pushed
the
quick-fix-dependency
branch
from
October 29, 2026 14:50
5f949a4 to
57d160b
Compare
github-project-automation
Bot
moved this from Review required
to Done
in neXtSIM_DG overview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build issue I had on CSD3.
The problem was in the configuration. It was building on my system since it just happened that
netcdflibraries were installed in the same as the other library (I think MPI but I am not sure). Anyway a search path provided with-Lwhen linking was correct by accident.This is a quick-fix to resolve the problem.
While investigated I have learned about the OBJECT libraries in CMake which may be better way to solve the problem static library is trying to solve. But this should be a follow-up issue.