Skip to content

chore: add subrequest note to NIC policies when WAF is enabled - #2213

Merged
JTorreG merged 6 commits into
mainfrom
nic/subrequests-waf-docs
Aug 20, 2026
Merged

chore: add subrequest note to NIC policies when WAF is enabled#2213
JTorreG merged 6 commits into
mainfrom
nic/subrequests-waf-docs

Conversation

@AlexFenlon

Copy link
Copy Markdown
Contributor

Add notices across NGINX Ingress Controller policy and WAF documentation to clarify that subrequests (e.g. externalAuth, remote JWKS, apiKey, OIDC, cache background update) do not work when WAF is enabled.

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

Add notices across NGINX Ingress Controller policy and WAF documentation
to clarify that subrequests (e.g. externalAuth, remote JWKS, apiKey,
OIDC, cache background update) do not work when WAF is enabled.
@AlexFenlon
AlexFenlon requested a review from a team as a code owner August 17, 2026 16:15
@github-actions github-actions Bot added documentation Improvements or additions to documentation product/nic Issues related to NGINX Ingress Controller labels Aug 17, 2026
@github-actions

Copy link
Copy Markdown

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/2213/

Comment thread content/nic/configuration/policy-resource.md Outdated
Comment thread content/nic/configuration/policy-resource.md Outdated
Comment thread content/nic/configuration/policy-resource.md Outdated
Comment thread content/nic/configuration/policy-resource.md Outdated
Comment thread content/nic/configuration/policy-resource.md Outdated
Comment thread content/nic/configuration/policy-resource.md Outdated
Comment thread content/nic/tutorials/oidc-custom-configuration.md Outdated
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Comment thread content/nic/configuration/policy-resource.md Outdated
Comment thread content/nic/tutorials/oidc-custom-configuration.md Outdated
JTorreG
JTorreG previously approved these changes Aug 17, 2026

@JTorreG JTorreG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with nits

AlexFenlon and others added 2 commits August 17, 2026 17:28
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
@JTorreG
JTorreG enabled auto-merge (squash) August 18, 2026 14:52

@pdabelf5 pdabelf5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language seems a bit strong. WAF & Auth policies do work together, you might get inconsistent results though. It might be better to suggest users avoid using combinations of WAF & Auth policies

@JTorreG
JTorreG self-requested a review August 19, 2026 13:10
@JTorreG
JTorreG dismissed their stale review August 19, 2026 13:11

removing my approval as the text needs to be revised

@JTorreG
JTorreG merged commit 079c95d into main Aug 20, 2026
9 checks passed
@JTorreG
JTorreG deleted the nic/subrequests-waf-docs branch August 20, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nic Issues related to NGINX Ingress Controller

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants