chore: add subrequest note to NIC policies when WAF is enabled - #2213
Merged
Conversation
Add notices across NGINX Ingress Controller policy and WAF documentation to clarify that subrequests (e.g. externalAuth, remote JWKS, apiKey, OIDC, cache background update) do not work when WAF is enabled.
✅ Deploy Preview will be available once build job completes!
|
JTorreG
reviewed
Aug 17, 2026
JTorreG
reviewed
Aug 17, 2026
JTorreG
reviewed
Aug 17, 2026
JTorreG
reviewed
Aug 17, 2026
JTorreG
reviewed
Aug 17, 2026
JTorreG
reviewed
Aug 17, 2026
JTorreG
reviewed
Aug 17, 2026
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
AlexFenlon
commented
Aug 17, 2026
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
JTorreG
enabled auto-merge (squash)
August 18, 2026 14:52
pdabelf5
reviewed
Aug 18, 2026
pdabelf5
left a comment
Contributor
There was a problem hiding this comment.
The language seems a bit strong. WAF & Auth policies do work together, you might get inconsistent results though. It might be better to suggest users avoid using combinations of WAF & Auth policies
JTorreG
self-requested a review
August 19, 2026 13:10
JTorreG
dismissed
their stale review
August 19, 2026 13:11
removing my approval as the text needs to be revised
pdabelf5
approved these changes
Aug 20, 2026
JTorreG
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add notices across NGINX Ingress Controller policy and WAF documentation to clarify that subrequests (e.g. externalAuth, remote JWKS, apiKey, OIDC, cache background update) do not work when WAF is enabled.
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩