Add Go Modules support (for Go >=1.11) #5
Conversation
nikhita
left a comment
nikhita
left a comment
There was a problem hiding this comment.
@ArionMiles sorry for the delaying in responding to this PR, and thanks for the improvements, really appreciate it! :)
| @@ -0,0 +1,12 @@ | |||
| module github.com/nikhita/github-contrib | |||
|
|
|||
| go 1.11 | |||
There was a problem hiding this comment.
Can you move this directly to 1.13 since that's the latest version?
There was a problem hiding this comment.
Isn't the go directive here used to specify the minimum go version?
I know you mention minimum go version as >=1.7 but for those using go<1.11, they'll not have any use for go.mod since it's not a feature in those versions.
So I thought adding go1.11 would be a good idea since people with those versions can still use the project.
|
I've removed go 1.11 specific instructions but I'm unsure whether updating |
I think it can be updated to 1.19 |
3 participants
No description provided.