Allow selecting a sender in the sign-transaction flow #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With an address list gated by required balance and auto-updating balances.
sisou
force-pushed
the
soeren/sign-tx-no-sender
branch
from
0898bae to
1d1dff8
Compare
danimoh
requested changes
Jul 7, 2025
|
|
||
| <AccountSelector | ||
| :wallets="processedWallets" | ||
| disableContracts |
Member
There was a problem hiding this comment.
For transaction signing, vesting contracts should be supported.
Comment on lines
16
to
+73
| public created() { | ||
| if (this.request.sender) { | ||
| this.forwardToKeyguard(this.request.sender); | ||
| return; | ||
| } | ||
| // If account not specified / found or is an unsupported Ledger account let the user pick another account. | ||
| // Don't automatically reject to not directly leak the information whether an account exists / is a Ledger. | ||
| this.syncStatus = this.$t('Contacting seed nodes...') as string; | ||
| this.showAccountSelector = true; | ||
| this.initNimiq(); | ||
| } |
Member
Comment on lines
+68
to
+69
| // If account not specified / found or is an unsupported Ledger account let the user pick another account. | ||
| // Don't automatically reject to not directly leak the information whether an account exists / is a Ledger. |
Member
There was a problem hiding this comment.
Ledger accounts do support transaction signing.
| // If account not specified / found or is an unsupported Ledger account let the user pick another account. | ||
| // Don't automatically reject to not directly leak the information whether an account exists / is a Ledger. | ||
| this.syncStatus = this.$t('Contacting seed nodes...') as string; |
Member
There was a problem hiding this comment.
To me, it feels nicer to move this line to initNimiq, or addConsensusListener as it's the case in CheckoutCardNimiq.
| await this.network.init(); | ||
| this.addConsensusListeners(); | ||
| this.updateBalancePromise = this.getBalances().then((balances) => { |
| }); | ||
| } | ||
| private async setAccount(walletId: string, address: string, isFromRequest = false) { |
Member
There was a problem hiding this comment.
setAccount is never called with true for isFromRequest, so it can be removed.
| public created() { | ||
| if (this.request.sender) { | ||
| this.forwardToKeyguard(this.request.sender); |
Member
There was a problem hiding this comment.
setAccount should be called instead, to run the existence check for the walletInfo.
Then actually with isFromRequest true.
| const addresses = accountsAndContracts.map((accountOrContract) => accountOrContract.userFriendlyAddress); | ||
| // Get balances through pico consensus, also triggers head-change event | ||
| const balances: Map<string, number> = await this.network.getBalance(addresses); |
Member
There was a problem hiding this comment.
This throws if no account is logged in.
| } | ||
| } | ||
| private goToOnboarding(useReplace?: boolean) { |
Member
There was a problem hiding this comment.
Never called with useReplace true.
| // Direct sign transaction request invocation | ||
| const signTransactionRequest = this.request as ParsedSignTransactionRequest; | ||
| if (!signTransactionRequest.sender) { | ||
| this.$rpc.reject(new Error('Ledger Transaction Signing expects a sender in the request.')); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an address list gated by required balance and auto-updating balances.
The balance-update code was pulled from
CheckoutCardNimiq.vue.