perf!: remove extra default nodeModulesDirs
#3798
Open
+19
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pi0
force-pushed
the
perf/extra-module-dirs
branch
from
6625aad to
ebd447e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were adding several
node_moduledirs (including workspace) to all resolutions, a requirement inherited from Nuxt to allow modules with non-hoisted dependencies to work.Removing extra
node_modulescan significantly help to reduce resolution times and also avoid wrong behaviors like picking dependencies from directories outside.If previous behavior is needed for any reason, users can directly configure
nodeModulesDirs