Fix json::update() with merge_objects==true error #5017
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash when using
update()on anordered_jsonobject whenJSON_DIAGNOSTICSis enabled.The Issue
When
update()inserts new elements into anordered_jsonobject, the underlyingstd::vectormay reallocate. This invalidates them_parentpointers of existing children, causingassert_invariantto fail immediately because the children point to the old memory address.The Fix
I have updated the
update()function to callset_parents()after insertion operations when diagnostics are enabled. This ensures that if the container moves in memory, all children are correctly updated to point to the new parent address.Reproduction Code