emit with callback given will always be called#7
Open
outbounder wants to merge 2 commits into
Open
Conversation
This resolves usage edge case described in detail at https://trello.com/c/9kQJgDkj/187-organic-plasma-and-callbacks + updates README + updates CHANGELOG + has passing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves usage edge case described in detail at https://trello.com/c/9kQJgDkj/187-organic-plasma-and-callbacks
the usage edge case
When doing
plasma.emit(..., callback)one expects to havecallbackinvoked when reaction gets hit and provides any feedback. However reactions which are one off implementations likeplasma.on(..., function (c) {})do not accept and thus do not invokecallback.Therefore this PR brings automatic callback invoke for those reactions which do not accept callback when invoked via
plasma.emitwith implicit callback argument.