test_runner: make it compatible with fake timers#59272
Open
mcollina wants to merge 2 commits intonodejs:mainfrom
Open
test_runner: make it compatible with fake timers#59272mcollina wants to merge 2 commits intonodejs:mainfrom
mcollina wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Member
|
Can you please add a test? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59272 +/- ##
=======================================
Coverage 89.64% 89.65%
=======================================
Files 676 676
Lines 206249 206326 +77
Branches 39518 39529 +11
=======================================
+ Hits 184892 184974 +82
+ Misses 13479 13474 -5
Partials 7878 7878
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 29, 2025
atlowChemi
approved these changes
Jul 29, 2025
MoLow
approved these changes
Aug 11, 2025
avivkeller
approved these changes
Jan 3, 2026
Collaborator
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
494d33b to
2779c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
setTimeoutis monkey-patched, it might be missing the symbol. Moreover, we plan to remove it in the future anyway in #58689.