-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
events: don't call resume after close (fix readline regression) #60548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b9ac594 to
2629acb
Compare
2629acb to
fc0cfb7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60548 +/- ##
==========================================
- Coverage 88.52% 88.52% -0.01%
==========================================
Files 704 704
Lines 208802 208884 +82
Branches 40318 40335 +17
==========================================
+ Hits 184842 184906 +64
- Misses 15947 15972 +25
+ Partials 8013 8006 -7
🚀 New features to boost your workflow:
|
fc0cfb7 to
9bedc04
Compare
b9076cd to
8f2e714
Compare
|
Rebased |
|
cc @jasnell @lpinca @dario-piotrowicz Can this get a review pls? |
lpinca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Fixes: #60507
Regression from: #58283
Since #58283, readline is not compatible with
EventEmitter.on(and readline own async iterator)It throws on attempting to
.resumethe stream after it was closed, which was whatEventEmitter.onwas doingAnother option is to make
.resumea noop in closed state instead of throwing