fs: fix errorOnExist behavior for directory copy in fs.cp #60946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
anonrig
approved these changes
Dec 3, 2025
npaun
force-pushed
the
fix-fs-cp-errorOnExist-directory
branch
from
5d975d2 to
b91cbae
Compare
dario-piotrowicz
approved these changes
Dec 3, 2025
juanarbol
approved these changes
Dec 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60946 +/- ##
==========================================
- Coverage 92.24% 88.51% -3.74%
==========================================
Files 344 704 +360
Lines 139442 208806 +69364
Branches 22294 40322 +18028
==========================================
+ Hits 128630 184826 +56196
- Misses 10587 15966 +5379
- Partials 225 8014 +7789
🚀 New features to boost your workflow:
|
npaun
force-pushed
the
fix-fs-cp-errorOnExist-directory
branch
from
b91cbae to
5c9b517
Compare
BethGriggs
approved these changes
Dec 4, 2025
github-actions
bot
removed
the
request-ci
Collaborator
cjihrig
approved these changes
Dec 4, 2025
Contributor
Author
|
Gentle bump on this PR, as it seems like the only blocker for landing is re-running CI due to flakes? |
lpinca
approved these changes
Dec 24, 2025
Member
|
CI is currently under security embargo. |
gurgunday
approved these changes
Dec 24, 2025
npaun
force-pushed
the
fix-fs-cp-errorOnExist-directory
branch
from
5c9b517 to
726ef1f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell
approved these changes
Jan 17, 2026
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 24b1650 |
aduh95
pushed a commit
that referenced
this pull request
Jan 20, 2026
PR-URL: #60946 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Dario Piotrowicz <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58947. This implements the errorOnExists check for onDir, which we previously had only for onFile.