-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
quic: copy options buffer instead of detaching #61403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Renegade334
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was going to suggest a similar approach.
The commit message should probably reflect that this applies to all buffer-based quic options, not just SessionOptions#certs.
da77e1e to
b8f90b8
Compare
The certs could be allocated in a pooled buffer, like `Buffer.from`, and `Buffer.allocUnsafe` (used by `fs.readFileSync`, etc).
b8f90b8 to
7a9130c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61403 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 704 704
Lines 208797 208806 +9
Branches 40316 40308 -8
==========================================
- Hits 184857 184834 -23
- Misses 15923 15971 +48
+ Partials 8017 8001 -16
🚀 New features to boost your workflow:
|
The
certscould be allocated in a pooled buffer, likeBuffer.from, andBuffer.allocUnsafe(used byfs.readFileSync, etc).Refs: #61372