test_runner: print failed coverage reports with dot runner#62078
Open
mizoz wants to merge 1 commit intonodejs:mainfrom
Open
test_runner: print failed coverage reports with dot runner#62078mizoz wants to merge 1 commit intonodejs:mainfrom
mizoz wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
When running tests with both the dot reporter and coverage reports, if the coverage report fails there was no output (other than the dots) but the program exits with a failure status code. This change adds coverage failure output to the dot reporter, similar to how the spec reporter handles coverage events. Now users can see why the command failed without needing to check F12 console. Fixes nodejs#60884 Signed-off-by: AZ & QZ <dev@local>
mizoz
force-pushed
the
test-runner-coverage-fix
branch
from
d71eee3 to
d0f8b20
Compare
Author
|
👋 Hi! I've rebased this PR on the latest main branch. The rebase was successful with no conflicts. CI checks are now pending and should start automatically. Once they complete, the PR should be ready for review by @nodejs/test_runner. Thanks! |
JakobJingleheimer
added
the
duplicate
Member
|
Duplicate of #61423 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60884
Summary
When running tests with both the dot reporter and coverage reports, if the coverage report fails there was no output (other than the dots) but the program exits with a failure status code.
This change adds coverage failure output to the dot reporter, similar to how the spec reporter handles coverage events. Now users can see why the command failed without needing to check F12 console.
Changes
getCoverageReportfrom reporter utilsTesting