module,win: fix long subpath import#62101
Open
StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
Open
module,win: fix long subpath import#62101StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
Conversation
StefanStojanovic
added
module
nodejs-github-bot
added
c++
StefanStojanovic
force-pushed
the
mefi-import-fix
branch
from
f6f2533 to
4c3bc3d
Compare
StefanStojanovic
force-pushed
the
mefi-import-fix
branch
from
4c3bc3d to
fe9c259
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62101 +/- ##
==========================================
- Coverage 91.62% 89.65% -1.98%
==========================================
Files 337 676 +339
Lines 140453 206333 +65880
Branches 21801 39519 +17718
==========================================
+ Hits 128694 184989 +56295
- Misses 11536 13467 +1931
- Partials 223 7877 +7654
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Mar 5, 2026
| BufferValue file_path_buf(realm->isolate(), | ||
| String::NewFromUtf8(realm->isolate(), | ||
| file_url->c_str(), | ||
| NewStringType::kNormal, |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| NewStringType::kNormal, | |
| NewStringType::kInternalized, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the linked issue and adds a regression test.
Fixes: #62043