Skip to content

tools: fix --node-builtin-modules-path value in shell.nix#62102

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:--node-builtin-modules-path
Mar 6, 2026
Merged

tools: fix --node-builtin-modules-path value in shell.nix#62102
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:--node-builtin-modules-path

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 4, 2026

A copy-paste error slipped through #61860

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Mar 4, 2026
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2026
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 4, 2026
@panva
Copy link
Member

panva commented Mar 5, 2026

unfortunately this doesn't fix the issue (for me at least on macOS)

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2026
@nodejs-github-bot nodejs-github-bot merged commit 798797a into nodejs:main Mar 6, 2026
39 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 798797a

@aduh95 aduh95 deleted the --node-builtin-modules-path branch March 6, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants