crypto: add TurboSHAKE and KangarooTwelve Web Cryptography algorithms#62183
Open
panva wants to merge 5 commits intonodejs:mainfrom
Open
crypto: add TurboSHAKE and KangarooTwelve Web Cryptography algorithms#62183panva wants to merge 5 commits intonodejs:mainfrom
panva wants to merge 5 commits intonodejs:mainfrom
Conversation
panva
added
semver-minor
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
panva
force-pushed
the
turbo-kangaroo
branch
2 times, most recently
from
4afe257 to
a9f6b32
Compare
panva
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Mar 10, 2026
| namespace { | ||
|
|
||
| inline uint64_t ROL64(uint64_t val, int offset) { | ||
| if (offset == 0) return val; |
Member
There was a problem hiding this comment.
This will fix an undefined behavior.
Suggested change
| if (offset == 0) return val; | |
| if (offset <= 0) return val; |
Member
Author
There was a problem hiding this comment.
The offset values come from the static rhotates table which only contains values 0–62, so this can never happen in practice.
anonrig
reviewed
Mar 10, 2026
Comment on lines
+29
to
+30
| if (offset == 0) return val; | ||
| return (val << offset) | (val >> (64 - offset)); |
Member
There was a problem hiding this comment.
Suggested change
| if (offset == 0) return val; | |
| return (val << offset) | (val >> (64 - offset)); | |
| offset &= 63; // reduce to [0, 63] | |
| if (offset == 0) return val; | |
| return (val << offset) | (val >> (64 - offset)); | |
| } |
Member
Author
There was a problem hiding this comment.
Same, the offsets are fixed values in the range of 0..62
anonrig
reviewed
Mar 10, 2026
| // Load/store 64-bit lanes in little-endian byte order. | ||
| // The Keccak state uses LE lane encoding (FIPS 202 Section 1, B.1). | ||
| // These helpers ensure correctness on both LE and BE platforms. | ||
| inline uint64_t LoadLE64(const uint8_t* src) { |
Member
There was a problem hiding this comment.
You need to have an assert somewhere making sure that src has size at least 8.
Member
Author
There was a problem hiding this comment.
These helpers are only called on the internal 200-byte Keccak state and fixed-size padding buffers. Same pattern as OpenSSL's keccak1600.c they're adapted from.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62183 +/- ##
==========================================
- Coverage 89.65% 89.64% -0.01%
==========================================
Files 676 678 +2
Lines 206546 206984 +438
Branches 39558 39632 +74
==========================================
+ Hits 185179 185553 +374
- Misses 13485 13516 +31
- Partials 7882 7915 +33
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RFC 9861 - KangarooTwelve and TurboSHAKE digest algorithm to Web Cryptography API per WICG/webcrypto-modern-algos#41 using adapted OpenSSL's keccak1600 implementation, to be replaced when OpenSSL supports them natively at which point we'd also make them available in stable
node:crypto.Refs: https://wicg.github.io/webcrypto-modern-algos/#kangarootwelve
Refs: https://wicg.github.io/webcrypto-modern-algos/#turboshake
Refs: https://www.rfc-editor.org/rfc/rfc9861.html
Refs: https://redirect.github.com/openssl/openssl/issues/30304
The tests for the implementation use both test vectors from the RFC as well as ones generated using PyCryptodome