Open
Conversation
953520d to
9026866
Compare
Contributor
Author
|
CC: |
richardlau
approved these changes
Mar 10, 2026
Collaborator
abmusse
approved these changes
Mar 10, 2026
Contributor
abmusse
left a comment
There was a problem hiding this comment.
LGTM, still will need to investigate the memory out of bounds error. Also would be good to unskip this on AIX and confirm if memory error occurs there too.
Member
|
Noting also that I've been getting some out of memory errors from these targets on RISC-V too so I feel that this new functionality is not working too well on quite a few platforms at the moment. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62189 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 676 676
Lines 206550 206550
Branches 39550 39553 +3
=======================================
+ Hits 185188 185189 +1
+ Misses 13500 13473 -27
- Partials 7862 7888 +26 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to AIX, IBMi build was timing out after this commit
Link for the build - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2252/console
@Richard-Lau applied the commit and after that we got the following error on IBMi
Link for the build - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2254/console
I need to reproduce and investigate what is causing the memory access out of bound issue