Skip to content

build: skip dockit on IBMi#62189

Open
sravani1510 wants to merge 1 commit intonodejs:mainfrom
sravani1510:dockit-code-skip-ibmi
Open

build: skip dockit on IBMi#62189
sravani1510 wants to merge 1 commit intonodejs:mainfrom
sravani1510:dockit-code-skip-ibmi

Conversation

@sravani1510
Copy link
Contributor

Similar to AIX, IBMi build was timing out after this commit

Link for the build - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2252/console

17:16:05 Building addon in /home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/benchmark/napi/type-tag
17:16:08 npm warn cli npm v11.11.0 does not support Node.js v26.0.0-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.
17:16:28 
17:16:28 added 315 packages, and audited 317 packages in 19s
17:16:28 
17:16:28 134 packages are looking for funding
17:16:28   run `npm fund` for details
17:16:28 
17:16:28 found 0 vulnerabilities
18:16:28 Build timed out (after 60 minutes). Marking the build as failed.
18:16:28 Build was aborted

@Richard-Lau applied the commit and after that we got the following error on IBMi

Link for the build - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2254/console

mkdir -p out/doc
19:39:57 cp doc/node-config-schema.json out/doc
19:39:57 mkdir -p out/doc/api
19:39:58 cp -r doc/api out/doc
19:41:03 (node:22467975) ExperimentalWarning: Importing WebAssembly module instances is an experimental feature and might change at any time
19:41:03 (Use `node --trace-warnings ...` to show where the warning was created)
19:41:09 [14:54:39.946] ERROR: memory access out of bounds
19:41:09 RuntimeError: memory access out of bounds
19:41:09     at wasm://wasm/001c7aca:wasm-function[165]:0x204ef
19:41:09     at wasm://wasm/001c7aca:wasm-function[196]:0x236f6
19:41:09     at new OnigScanner (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/engine-oniguruma/dist/index.mjs:306:36)
19:41:09     at Object.createScanner (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/engine-oniguruma/dist/index.mjs:440:14)
19:41:09     at Object.createOnigScanner (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/core/dist/index.mjs:1871:47)
19:41:09     at Grammar.createOnigScanner (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/vscode-textmate/dist/index.js:2342:26)
19:41:09     at new CompiledRule (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/vscode-textmate/dist/index.js:1667:28)
19:41:09     at RegExpSourceList._resolveAnchors (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/vscode-textmate/dist/index.js:1660:12)
19:41:09     at RegExpSourceList.compileAG (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/vscode-textmate/dist/index.js:1639:44)
19:41:11     at IncludeOnlyRule.compileAG (file:///home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/tools/doc/node_modules/@shikijs/vscode-textmate/dist/index.js:1110:53)gmake[1]: *** [Makefile:845: out/doc/api/addons.html] Error 1
19:41:11 gmake: *** [Makefile:647: run-ci] Error 2

I need to reproduce and investigate what is causing the memory access out of bound issue

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 10, 2026
@sravani1510 sravani1510 force-pushed the dockit-code-skip-ibmi branch from 953520d to 9026866 Compare March 10, 2026 16:59
@sravani1510
Copy link
Contributor Author

sravani1510 commented Mar 10, 2026

CC:
@nodejs/platform-aix
@nodejs/platform-ibmi

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2026
@nodejs-github-bot
Copy link
Collaborator

@abmusse abmusse self-requested a review March 10, 2026 17:22
Copy link
Contributor

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still will need to investigate the memory out of bounds error. Also would be good to unskip this on AIX and confirm if memory error occurs there too.

@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Mar 10, 2026
@sxa
Copy link
Member

sxa commented Mar 10, 2026

Noting also that I've been getting some out of memory errors from these targets on RISC-V too so I feel that this new functionality is not working too well on quite a few platforms at the moment.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (95ee87d) to head (9026866).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62189   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         676      676           
  Lines      206550   206550           
  Branches    39550    39553    +3     
=======================================
+ Hits       185188   185189    +1     
+ Misses      13500    13473   -27     
- Partials     7862     7888   +26     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants