[v24.x backport] sea: add --build-sea and support ESM entry point#62190
Open
himself65 wants to merge 6 commits intonodejs:v24.x-stagingfrom
Open
[v24.x backport] sea: add --build-sea and support ESM entry point#62190himself65 wants to merge 6 commits intonodejs:v24.x-stagingfrom
himself65 wants to merge 6 commits intonodejs:v24.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
himself65
force-pushed
the
v24.x-staging
branch
2 times, most recently
from
439b04c to
7124701
Compare
Instead of relying on a WASM build of postject to perform the injection, add LIEF as dependency and generate the SEA directly from core via a new CLI option --build-sea which takes the SEA config. This simplifies SEA generation for users and makes it easier to debug/maintain the SEA building process. PR-URL: nodejs#61167 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Only leave a smoking test for the postject-based workflow in test-single-executable-application.js PR-URL: nodejs#61167 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: nodejs#61581 Refs: nodejs#61579 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: nodejs#61708 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This uses the new StartExecutionCallbackWithModule embedder API to support ESM entrypoint in SEA via a new configuration field `"mainFormat"`. The behavior currently aligns with the embedder API and is mostly in sync with the CommonJS entry point behavior, except that support for code caching and snapshot is left for follow-ups. PR-URL: nodejs#61813 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This adds a embedder_module_hdo for identifying embedder-run modules in the dynamic import handler and import.meta initializer, and a SourceTextModuleTypes for customizing source text module compilation in the JS land via compileSourceTextModule(). Also, refactors the existing embedder module compilation code to reuse the builtin resolution logic. PR-URL: nodejs#61654 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
himself65
force-pushed
the
v24.x-staging
branch
from
7124701 to
fb276ad
Compare
himself65
added
request-ci
github-actions
bot
added
request-ci-failed
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/22922894129 |
himself65
removed
the
request-ci-failed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #62190 +/- ##
=================================================
- Coverage 90.10% 90.06% -0.05%
=================================================
Files 667 671 +4
Lines 199019 200746 +1727
Branches 38911 39141 +230
=================================================
+ Hits 179335 180807 +1472
- Misses 12040 12244 +204
- Partials 7644 7695 +51
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport the
--build-seaflag and ESM entry point support for Single Executable Applications to v24.x.Cherry-picked from:
--build-seadefault executable path #61708 (fix default executable path)Refs: #62119