doc: fix outdated debugger, worker_threads, and fs.stat docs#62197
Open
kovan wants to merge 3 commits intonodejs:mainfrom
Open
doc: fix outdated debugger, worker_threads, and fs.stat docs#62197kovan wants to merge 3 commits intonodejs:mainfrom
kovan wants to merge 3 commits intonodejs:mainfrom
Conversation
Remove the Chrome 66.0.3345.0 version check (Chrome 66 shipped in 2018), the claim that Chrome DevTools doesn't support debugging worker threads (which uses time-tied language), and the recommendation to use ndb (which has been archived since July 2023). Fixes: nodejs#54078 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The example claimed that posting a URL object via MessageChannel would print an empty object, but since v21.0.0 (commit d920b7c) it throws a DataCloneError. Update the example and surrounding text to reflect the current behavior. Fixes: nodejs#60504 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR nodejs#61178 added the throwIfNoEntry option to fs.stat and fsPromises.stat (shipped in v25.7.0) but did not add corresponding YAML version history entries. The sync variants (fs.statSync, fs.lstatSync) already had history entries from PR nodejs#33716. Fixes: nodejs#62185 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postMessage(new URL(...))example that claims to print{}but actually throwsDataCloneErrorsince v21.0.0 (d920b7c)throwIfNoEntryoption onfs.statandfsPromises.stat(added in v25.7.0 via fs: addthrowIfNoEntryoption for fs.stat and fs.promises.stat #61178; the sync variants already had entries from lib: add throws option to fs.f/l/statSync #33716)Fixes: #54078
Fixes: #60504
Fixes: #62185
Verification
All changes verified against source code:
src/node_messaging.cc: confirmedDataCloneErrorfor non-serializable objects since src: throw DOMException on cloning non-serializable objects #47839lib/fs.js/lib/internal/fs/promises.js: confirmedthrowIfNoEntryadded in fs: addthrowIfNoEntryoption for fs.stat and fs.promises.stat #61178git tag --contains 4cecbe1f53f→ v25.7.0 (first release withthrowIfNoEntryfor stat)git tag --contains d920b7c94b8→ v21.0.0 (first release throwingDataCloneError)🤖 Generated with Claude Code