doc: remove spawn with shell example from bat/cmd section#62243
Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom Mar 23, 2026
Merged
doc: remove spawn with shell example from bat/cmd section#62243nodejs-github-bot merged 5 commits intonodejs:mainfrom
nodejs-github-bot merged 5 commits intonodejs:mainfrom
Conversation
Remove the suggestion to use child_process.spawn() with the shell option set for running .bat and .cmd files on Windows. Passing arguments through spawn with shell: true is deprecated (DEP0190) due to shell injection risks. Keep the exec() and direct cmd.exe spawn alternatives. Fixes: nodejs#58735
nodejs-github-bot
added
child_process
aduh95
reviewed
Mar 14, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Mar 17, 2026
aduh95
reviewed
Mar 17, 2026
Apply remaining review suggestions from aduh95: - Add spawn+shell back to the list with (not recommended, see DEP0190) - Fix DEP0190 link reference to use full anchor
Contributor
Why? |
Contributor
Author
|
Fixed, reverted to the short anchor you suggested. Sorry about that. |
aduh95
approved these changes
Mar 18, 2026
aduh95
added
commit-queue
StefanStojanovic
approved these changes
Mar 23, 2026
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 22fc52b |
aduh95
pushed a commit
that referenced
this pull request
Mar 25, 2026
Remove the suggestion to use child_process.spawn() with the shell option set for running .bat and .cmd files on Windows. Passing arguments through spawn with shell: true is deprecated (DEP0190) due to shell injection risks. Keep the exec() and direct cmd.exe spawn alternatives. Fixes: #58735 PR-URL: #62243 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the suggestion to use
child_process.spawn()with theshelloption for running
.batand.cmdfiles on Windows. Passing argumentsthrough
spawnwithshell: trueis deprecated (DEP0190) due toshell injection risks. The
exec()and directcmd.exespawnalternatives remain documented.
Continues the work from #58739 which addressed the same issue but
stale-closed without review.
Fixes: #58735