Skip to content

doc: remove obsolete --napi-modules doc entry#64220

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:cli-napi-modules
Jul 7, 2026
Merged

doc: remove obsolete --napi-modules doc entry#64220
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:cli-napi-modules

Conversation

@legendecas

Copy link
Copy Markdown
Member

--napi-modules has been a no-op for a long time. Remove it from the doc.

It is still kept as a no-op option.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 30, 2026
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
@legendecas legendecas added the node-api Issues and PRs related to the Node-API. label Jun 30, 2026
@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Jun 30, 2026
@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 1, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 2, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64220
✔  Done loading data for nodejs/node/pull/64220
----------------------------------- PR info ------------------------------------
Title      doc: remove obsolete --napi-modules doc entry (#64220)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     legendecas:cli-napi-modules -> nodejs:main
Labels     node-api, author ready, needs-ci
Commits    1
 - doc: remove obsolete --napi-modules doc entry
Committers 1
 - Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/64220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Jun 2026 18:52:29 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64220#pullrequestreview-4603771320
   ✔  - Adrian Estrada (@edsadr): https://github.com/nodejs/node/pull/64220#pullrequestreview-4603915973
   ✔  - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/64220#pullrequestreview-4604828357
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/64220#pullrequestreview-4610678742
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-07-01T14:52:45Z: https://ci.nodejs.org/job/node-test-pull-request/74493/
- Querying data for job/node-test-pull-request/74493/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 64220
From https://github.com/nodejs/node
 * branch                  refs/pull/64220/merge -> FETCH_HEAD
✔  Fetched commits as b2e83150cb54..94da5035468e
--------------------------------------------------------------------------------
Auto-merging doc/api/cli.md
[main 41b4e7f163] doc: remove obsolete --napi-modules doc entry
 Author: Chengzhong Wu <cwu631@bloomberg.net>
 Date: Tue Jun 30 14:49:37 2026 -0400
 4 files changed, 2 insertions(+), 15 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
doc: remove obsolete --napi-modules doc entry

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #64220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>

[main 1360e63644] doc: remove obsolete --napi-modules doc entry
Author: Chengzhong Wu <cwu631@bloomberg.net>
Date: Tue Jun 30 14:49:37 2026 -0400
4 files changed, 2 insertions(+), 15 deletions(-)
✔ 1360e6364443ed602d0e4dff94ebc33a6c0aae4f
✔ 0:0 no Assisted-by metadata assisted-by-is-trailer
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 2:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
⚠ 1:0 "Signed-off-by" email does not match the commit author email signed-off-by
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

The following commits are landable on origin/main

  • 1360e63644 doc: remove obsolete --napi-modules doc entry

  • Removing temporary files
    ✔ Temporary files removed.
    To finish landing:
  1. Run:
    git push origin main
  2. Post "Landed in 1360e6364443" in doc: remove obsolete --napi-modules doc entry #64220
    gh pr comment doc: remove obsolete --napi-modules doc entry #64220 --body "Landed in 1360e6364443"
    gh pr close doc: remove obsolete --napi-modules doc entry #64220
https://github.com/nodejs/node/actions/runs/28615542785

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 7, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2026
@nodejs-github-bot nodejs-github-bot merged commit 94164da into nodejs:main Jul 7, 2026
84 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 94164da

@github-project-automation github-project-automation Bot moved this from In Progress to Done in Node-API Team Project Jul 7, 2026
@legendecas legendecas deleted the cli-napi-modules branch July 7, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

Development

Successfully merging this pull request may close these issues.

6 participants