You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ui-components package had react listed under dependencies. When published, this metadata structure forces consumer applications running a different sub-version of React 19 to install a duplicate instance of React, triggering runtime Invalid hook call errors.
Changes
To resolve external runtime duplication while preserving strict React 19 compatibility and seamless local workspace development, this PR applies the following:
Moved react to peerDependencies in packages/ui-components/package.json using the catalog:peer-react19 protocol to delegate runtime React resolution to the host/consumer application.
Duplicated react in devDependencies to guarantee that local package builds (pnpm build), test utilities, and TypeScript types compilation inside the isolated package directory do not break.
Aligned pnpm Catalogs (pnpm-workspace.yaml): Configured catalog:peer-react19 to target a loose ^19.0.0 range. When the library is published, pnpm will substitute the catalog protocol with a standard open SemVer range (^19.0.0) matching any consumer's native React 19 installation.
Added a Changeset: Generated a patch bump changeset (.changeset/cozy-teeth-speak.md) to comply with the workspace publishing policy.
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.11%. Comparing base (842e9ae) to head (9301469). ⚠️ Report is 19 commits behind head on main.
✅ All tests successful. No failed tests found.
Yes, definitely. Keeping React in dependencies causes duplicate React installations in consumer apps if their React 19 version doesn't match exactly. This leads to broken hooks at runtime. peerDependencies is the standard way to fix this.
I'm currently working on improving the external usage experience of the library, so this change is essential.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
ui-componentspackage hadreactlisted underdependencies. When published, this metadata structure forces consumer applications running a different sub-version of React 19 to install a duplicate instance of React, triggering runtimeInvalid hook callerrors.Changes
To resolve external runtime duplication while preserving strict React 19 compatibility and seamless local workspace development, this PR applies the following:
reacttopeerDependenciesinpackages/ui-components/package.jsonusing thecatalog:peer-react19protocol to delegate runtime React resolution to the host/consumer application.reactindevDependenciesto guarantee that local package builds (pnpm build), test utilities, and TypeScript types compilation inside the isolated package directory do not break.pnpm-workspace.yaml): Configuredcatalog:peer-react19to target a loose^19.0.0range. When the library is published, pnpm will substitute the catalog protocol with a standard open SemVer range (^19.0.0) matching any consumer's native React 19 installation..changeset/cozy-teeth-speak.md) to comply with the workspace publishing policy.Fixes #9175