Remove find_dependency for not installed module#313
Open
cho-m wants to merge 1 commit intonodejs:mainfrom
Open
Remove find_dependency for not installed module#313cho-m wants to merge 1 commit intonodejs:mainfrom
cho-m wants to merge 1 commit intonodejs:mainfrom
Conversation
guybedford
approved these changes
Sep 17, 2025
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Pending resolution of the unrelated CI failure, this seems fine to me.
Author
I think it may be fixed by rerunning CI as GitHub reverted CMake 4 change actions/runner-images#13032 EDIT: Just noting that the specific issue with CMake 4 is from fetched libuv < 1.47.0 - libuv/libuv@124d55c |
Signed-off-by: Michael Cho <michael@michaelcho.dev>
cho-m
force-pushed
the
fix-cmake-config
branch
from
fcc0be0 to
a0cc710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
find_dependencyisn't used on standard installations, i.e. find module isn't installed and many repositories don't include CMake config file in libuv (and the upper/lowercase is wrong for either).At build time, the paths from FindLIBUV are already saved in uvwasiTargets.cmake so this doesn't seem necessary.