security(#301): harden webhook spool (0700 dir, O_NOFOLLOW, 0600)#311
Draft
nolanmak wants to merge 1 commit into
Draft
security(#301): harden webhook spool (0700 dir, O_NOFOLLOW, 0600)#311nolanmak wants to merge 1 commit into
nolanmak wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #301.
Hardens the webhook spool against the local symlink/poisoning attack (which bypassed the HTTP-route HMAC, since the real trust boundary was an unprotected
/tmpfile)./tmpinto a per-user 0700 state dir (${XDG_RUNTIME_DIR}/augmentagentor~/.local/state/augmentagent) — matching the convention the Rust crates already use.appendHardened()creates the dir0700and opens withO_APPEND|O_CREAT|O_WRONLY|O_NOFOLLOWat mode0600, so a pre-planted symlink throws ELOOP instead of redirecting writes.AUGMENTAGENT_WEBHOOK_SPOOL/AUGMENTAGENT_DEFT_SEENenv overrides are unchanged.Only
src/webhooks.tschanged. No Rust change needed — grep of all 36 crates found no consumer of the spool path/env (confirmed).Verification:
npm install+npx tsc --noEmitpass (exit 0).🤖 swarm-authored, human-review-required (draft).