Performance #116
Open
Performance #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 6, 2019 17:16
Contributor
|
While I have not confirmed if this actually improves speed (i have a hunch it does), I have tested this PR with the latest codebase and can confirm it works. |
Author
|
It's fairly easy to test, if you use MlpPolicy on the agent (it's just a bit faster and more visual) , what I've noticed is that after about 2-3 minutes of running optimization the whole thing really slows down. If you look at the code in the _next_observation it keeps adding new observations to the frame and does all recalculations on the full frame so as the list grows it becomes slower. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.