Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 6, 2026 04:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes #909.
What / Why
intersects('>*', '*'),intersects('<*', '*'), andintersects('<0.0.0', '*')currently return true. The wildcard shortcut inComparator.intersectsreturns before the existing empty-range checks.Move the wildcard success case after those checks, while retaining exact-version comparisons first. This also makes an exact prerelease intersect a wildcard consistently in both argument orders: false by default, true with
includePrerelease.Add comparator and range fixtures covering both argument orders, loose mode, public and Comparator entry points,
includePrerelease, nonempty boundary controls, and OR ranges. The existing lower-bound and general prerelease-intersection algorithms are unchanged.Validation: regressions fail on the unchanged base; full
npm testpasses all 51 files with 100% statement, branch, function and line coverage, plus ESLint and template checks. Tested on Linux/Node24.19.0. The remote CI platform/version matrix has not been run locally.Prepared with OpenAI Codex assistance.