Skip to content

Conversation

@wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Jan 31, 2026

Note

This PR has an alternative: #452

Following Node.js decision not to include Corepack in future versions of Node.js, I suggest replacing it with pnpm/action-setup, which not only removes dependency on Corepack, but also fixes dependency caching which, if you study CI logs, despite being setup correctly, simply does not seem to work.

Without cache: https://github.com/npmx-dev/npmx.dev/actions/runs/21535589549/job/62060513946

With cache: https://github.com/npmx-dev/npmx.dev/actions/runs/21535614560/job/62060587748

@vercel
Copy link

vercel bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 31, 2026 0:41am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jan 31, 2026 0:41am
npmx-lunaria Ignored Ignored Jan 31, 2026 0:41am

Request Review

Following Node.js decision not to include Corepack in future versions of Node.js, I suggest replacing it with pnpm/action-setup, which not only removes dependency on Corepack, but also fixes dependency caching which, if you study CI logs, despite being setup correctly, simply does not seem to work.
Copy link
Collaborator

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 This makes sense to me. In a few months we won't have built-in corepack anyway.

@serhalp serhalp added this pull request to the merge queue Jan 31, 2026
Merged via the queue into npmx-dev:main with commit 9a71fa4 Jan 31, 2026
15 checks passed
@wojtekmaj wojtekmaj deleted the pnpm-action-with-caching branch January 31, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants