Skip to content

fix: don't rely on pkg.updated for update date #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Jan 31, 2026
Merged

fix: don't rely on pkg.updated for update date #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/components/PackageTableRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ const emit = defineEmits<{
const pkg = computed(() => props.result.package)
const score = computed(() => props.result.score)

// Get the best available date: prefer result.updated (from packument), fall back to package.date
const updatedDate = computed(() => props.result.updated ?? props.result.package.date)
const updatedDate = computed(() => props.result.package.date)

function formatDownloads(count?: number): string {
if (count === undefined) return '-'
Expand Down
6 changes: 2 additions & 4 deletions app/composables/useStructuredFilters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export function useStructuredFilters(options: UseStructuredFiltersOptions) {
const config = UPDATED_WITHIN_OPTIONS.find(o => o.value === within)
if (!config?.days) return true

const updatedDate = new Date(pkg.updated ?? pkg.package.date)
const updatedDate = new Date(pkg.package.date)
const cutoff = new Date()
cutoff.setDate(cutoff.getDate() - config.days)
return updatedDate >= cutoff
Expand Down Expand Up @@ -260,9 +260,7 @@ export function useStructuredFilters(options: UseStructuredFiltersOptions) {
diff = (a.downloads?.weekly ?? 0) - (b.downloads?.weekly ?? 0)
break
case 'updated':
diff =
new Date(a.updated ?? a.package.date).getTime() -
new Date(b.updated ?? b.package.date).getTime()
diff = new Date(a.package.date).getTime() - new Date(b.package.date).getTime()
break
case 'name':
diff = a.package.name.localeCompare(b.package.name)
Expand Down
4 changes: 2 additions & 2 deletions app/pages/~[username]/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ const filteredAndSortedPackages = computed(() => {
switch (sortOption.value) {
case 'updated':
pkgs.sort((a, b) => {
const dateA = a.updated || a.package.date || ''
const dateB = b.updated || b.package.date || ''
const dateA = a.package.date || ''
const dateB = b.package.date || ''
return dateB.localeCompare(dateA)
})
break
Expand Down
Loading