Repository navigation
Give the REPL's partial-line test room on slow machines - #37
Merged
Merged
Conversation
The REPL holds the start of a line for a quarter of a second, and the test printed the rest of each line 100ms later. A busy macOS runner stretched that past the quarter of a second, so a step came out in two pieces. 20ms leaves the test the same while keeping well inside the wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
output-test failed once on macOS because the 100ms between a step's start and its "done" got stretched past the quarter of a second the REPL waits. 20ms still splits each line across two messages.