Repository navigation
Lay Java docs out the way their Javadoc's HTML has them - #39
Merged
Merged
Conversation
cider-nrepl's doc fragments for a Java class or member mix text with HTML, which neorepl stripped of its tags. Tables came out as runs of blank lines, lists without their items, entities like \ as they were, generics like Map<K, V> without <K, V>, a space before the punctuation after each code span, and the lines after the first without a docstring's indent. The fragments now go through one walk that lays the HTML out about as a browser would: paragraphs, list items and table rows on lines of their own, cells between bars, code blocks indented, entities spelled out, and the HTML's whitespace ignored next to the text, as orchard says it should be. orchard also puts a space between everything it joins in that HTML, which splits words at entities, Fahrvergnügen into "Fahrvergn ü gen" (orchard#438). neorepl takes those out for cider-nrepl before 0.64.0, going by the version describe reports, which the client now keeps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spaces orchard puts around entities only get taken out for cider-nrepl before 0.64.0, its prereleases included, since a fixed orchard sends
a < bwith spaces that belong there. That makes 0.64.0 the release that has to carry clojure-emacs/orchard#438.