Add nrf_cc310_platform library #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diondokter
reviewed
Nov 5, 2024
Cargo.toml
Outdated
| description = "Rust bindings to the Nordic nRF91* Socket Library." | ||
| readme = "README.md" | ||
| license-file = "LICENCE.md" | ||
| license-file = "LICENSE.md" |
Contributor
There was a problem hiding this comment.
Why the change? It was correct
Contributor
Author
There was a problem hiding this comment.
That was just the spelling, this does not necessarily need to be in this pull request.
README.md
Outdated
Comment on lines
61
to
65
| ## License | ||
|
|
||
| Any of the code outside the `./third_party` folder is under the [Blue Oak | ||
| Licence](./LICENCE.md). Any code inside the `./third_party` folder (include | ||
| the Nordic nrfxlib) has its own LICENCE file. | ||
| License](./LICENSE.md). Any code inside the `./third_party` folder (include | ||
| the Nordic nrfxlib) has its own LICENSE file. |
Contributor
There was a problem hiding this comment.
This wasn't a spelling mistake. This repo was started by a Brit and 'licence' is the way you write it in british. Please revert
diondokter
reviewed
Nov 5, 2024
Cargo.toml
Outdated
|
|
||
| [features] | ||
| default = ["llvm-objcopy"] | ||
| default = ["llvm-objcopy", "nrf9160"] |
Contributor
There was a problem hiding this comment.
While nice for nrf9160 users, this is a slight annoyance for users of other chips. It was a deliberate decision to have it as it was
Contributor
Author
There was a problem hiding this comment.
Oversight on my part.
Contributor
Author
|
Modifications as requested. |
diondokter
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.